Add tests for DRIs in scala3doc #10337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
requested changes
Nov 18, 2020
Contributor
romanowski
left a comment
romanowski
left a comment
There was a problem hiding this comment.
Beside those printlns code looks ok
romanowski
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for DRIs generated by doctool. Unique DRIs are crucial for linking inside the documentation to work properly. Fortunately, scala has rather strict rules for avoiding double definitions what makes declaring unique DRIs easy. Nevertheless, those tests have found at least 3 different problems with DRI generation. The cases verifying them are ignored or commented out.
Reported issues: